Merged
Conversation
* requires removal of .NET 8 targets ... error NETSDK1202: The workload 'net8.0-android' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/maui-support-policy for more information about the support policy.
* and upate XCode in GHA
* in order to speed up this step of the build jobs, which is taking particularly long (especially on MacOS)
There was a problem hiding this comment.
Pull request overview
Updates the MAUI sample and the OxyPlot MAUI Skia library to target .NET 10 and adjusts the CI workflow accordingly.
Changes:
- Bumped MAUI project target frameworks to
net10.0-*(and library to includenet10.0alongsidenet9.0). - Updated GitHub Actions to use
.NET 10.0.xand simplified workload installation. - Adjusted CI build commands/flags (including switching sample build to Debug).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Source/OxyplotMauiSample/OxyplotMauiSample.csproj | Updates sample app TFMs to .NET 10 variants. |
| Source/OxyPlot.Maui.Skia/OxyPlot.Maui.Skia.csproj | Updates library TFMs to include .NET 10 variants and drop older ones. |
| .github/workflows/dotnet.yml | Moves CI to .NET 10 and tweaks workload install/build steps (including Xcode pin). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.